Fix 2 code smell

This commit is contained in:
2023-03-13 16:56:09 +01:00
parent 7551b0d669
commit d9a6f528f6
3 changed files with 10 additions and 8 deletions

View File

@@ -1,7 +1,9 @@
{ {
"sonarlint.connectedMode.project": { "sonarlint.connectedMode.project": {
"connectionId": "sonarcloud", "connectionId": "rmontanana",
"projectKey": "rmontanana_mdlp" "projectKey": "rmontanana_mdlp"
}, },
"C_Cpp.default.configurationProvider": "ms-vscode.cmake-tools" "C_Cpp.default.configurationProvider": "ms-vscode.cmake-tools",
"cmake.configureOnOpen": true,
"sonarlint.pathToCompileCommands": "${workspaceFolder}/build/compile_commands.json"
} }

View File

@@ -15,7 +15,7 @@ namespace mdlp {
CPPFImdlp::CPPFImdlp() = default; CPPFImdlp::CPPFImdlp() = default;
CPPFImdlp::~CPPFImdlp() = default; CPPFImdlp::~CPPFImdlp() = default;
size_t CPPFImdlp::compute_max_num_cut_points() size_t CPPFImdlp::compute_max_num_cut_points() const
{ {
// Set the actual maximum number of cut points as a number or as a percentage of the number of samples // Set the actual maximum number of cut points as a number or as a percentage of the number of samples
if (proposed_cuts == 0) { if (proposed_cuts == 0) {
@@ -25,8 +25,8 @@ namespace mdlp {
throw invalid_argument("wrong proposed num_cuts value"); throw invalid_argument("wrong proposed num_cuts value");
} }
if (proposed_cuts < 1) if (proposed_cuts < 1)
return (int)round(X.size() * proposed_cuts); return static_cast<size_t>(round(X.size() * proposed_cuts));
return (int)proposed_cuts; return static_cast<size_t>(proposed_cuts);
} }
void CPPFImdlp::fit(samples_t& X_, labels_t& y_) void CPPFImdlp::fit(samples_t& X_, labels_t& y_)
@@ -174,7 +174,7 @@ namespace mdlp {
sort(cutPoints.begin(), cutPoints.end()); sort(cutPoints.begin(), cutPoints.end());
return cutPoints; return cutPoints;
} }
int CPPFImdlp::get_depth() int CPPFImdlp::get_depth() const
{ {
return depth; return depth;
} }

View File

@@ -22,7 +22,7 @@ namespace mdlp {
void computeCutPoints(size_t, size_t, int); void computeCutPoints(size_t, size_t, int);
bool mdlp(size_t, size_t, size_t); bool mdlp(size_t, size_t, size_t);
size_t getCandidate(size_t, size_t); size_t getCandidate(size_t, size_t);
size_t compute_max_num_cut_points(); size_t compute_max_num_cut_points() const;
pair<precision_t, size_t> valueCutPoint(size_t, size_t, size_t); pair<precision_t, size_t> valueCutPoint(size_t, size_t, size_t);
public: public:
CPPFImdlp(); CPPFImdlp();
@@ -30,7 +30,7 @@ namespace mdlp {
~CPPFImdlp(); ~CPPFImdlp();
void fit(samples_t&, labels_t&); void fit(samples_t&, labels_t&);
cutPoints_t getCutPoints(); cutPoints_t getCutPoints();
int get_depth(); int get_depth() const;
inline string version() { return "1.1.1"; }; inline string version() { return "1.1.1"; };
}; };
} }