From d9a6f528f69803de5228ef8c5ecb412821185dfc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ricardo=20Monta=C3=B1ana?= <rmontanana@gmail.com>
Date: Mon, 13 Mar 2023 16:56:09 +0100
Subject: [PATCH] Fix 2 code smell

---
 .vscode/settings.json | 6 ++++--
 CPPFImdlp.cpp         | 8 ++++----
 CPPFImdlp.h           | 4 ++--
 3 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index b89d404..85f6c83 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,7 +1,9 @@
 {
     "sonarlint.connectedMode.project": {
-        "connectionId": "sonarcloud",
+        "connectionId": "rmontanana",
         "projectKey": "rmontanana_mdlp"
     },
-    "C_Cpp.default.configurationProvider": "ms-vscode.cmake-tools"
+    "C_Cpp.default.configurationProvider": "ms-vscode.cmake-tools",
+    "cmake.configureOnOpen": true,
+    "sonarlint.pathToCompileCommands": "${workspaceFolder}/build/compile_commands.json"
 }
\ No newline at end of file
diff --git a/CPPFImdlp.cpp b/CPPFImdlp.cpp
index 0cd833c..b09af46 100644
--- a/CPPFImdlp.cpp
+++ b/CPPFImdlp.cpp
@@ -15,7 +15,7 @@ namespace mdlp {
     CPPFImdlp::CPPFImdlp() = default;
     CPPFImdlp::~CPPFImdlp() = default;
 
-    size_t CPPFImdlp::compute_max_num_cut_points()
+    size_t CPPFImdlp::compute_max_num_cut_points() const
     {
         // Set the actual maximum number of cut points as a number or as a percentage of the number of samples
         if (proposed_cuts == 0) {
@@ -25,8 +25,8 @@ namespace mdlp {
             throw invalid_argument("wrong proposed num_cuts value");
         }
         if (proposed_cuts < 1)
-            return (int)round(X.size() * proposed_cuts);
-        return (int)proposed_cuts;
+            return static_cast<size_t>(round(X.size() * proposed_cuts));
+        return static_cast<size_t>(proposed_cuts);
     }
 
     void CPPFImdlp::fit(samples_t& X_, labels_t& y_)
@@ -174,7 +174,7 @@ namespace mdlp {
         sort(cutPoints.begin(), cutPoints.end());
         return cutPoints;
     }
-    int CPPFImdlp::get_depth()
+    int CPPFImdlp::get_depth() const
     {
         return depth;
     }
diff --git a/CPPFImdlp.h b/CPPFImdlp.h
index f7364c2..574d8cb 100644
--- a/CPPFImdlp.h
+++ b/CPPFImdlp.h
@@ -22,7 +22,7 @@ namespace mdlp {
         void computeCutPoints(size_t, size_t, int);
         bool mdlp(size_t, size_t, size_t);
         size_t getCandidate(size_t, size_t);
-        size_t compute_max_num_cut_points();
+        size_t compute_max_num_cut_points() const;
         pair<precision_t, size_t> valueCutPoint(size_t, size_t, size_t);
     public:
         CPPFImdlp();
@@ -30,7 +30,7 @@ namespace mdlp {
         ~CPPFImdlp();
         void fit(samples_t&, labels_t&);
         cutPoints_t getCutPoints();
-        int get_depth();
+        int get_depth() const;
         inline string version() { return "1.1.1"; };
     };
 }