rmontanana/mdlp
1
1
Fork 0
mirror of https://github.com/rmontanana/mdlp.git synced 2025-08-18 17:05:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix 2 code smell

Browse Source
This commit is contained in:
Ricardo Montañana Gómez
2023-03-13 16:56:09 +01:00
parent 7551b0d669
commit d9a6f528f6
3 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
CPPFImdlp.cpp
View File

@@ -15,7 +15,7 @@ namespace mdlp {
CPPFImdlp::CPPFImdlp() = default;
CPPFImdlp::~CPPFImdlp() = default;
size_t CPPFImdlp::compute_max_num_cut_points()
size_t CPPFImdlp::compute_max_num_cut_points() const
{
// Set the actual maximum number of cut points as a number or as a percentage of the number of samples
if (proposed_cuts == 0) {
@@ -25,8 +25,8 @@ namespace mdlp {
throw invalid_argument("wrong proposed num_cuts value");
}
if (proposed_cuts < 1)
return (int)round(X.size() * proposed_cuts);
return (int)proposed_cuts;
return static_cast<size_t>(round(X.size() * proposed_cuts));
return static_cast<size_t>(proposed_cuts);
}
void CPPFImdlp::fit(samples_t& X_, labels_t& y_)
@@ -174,7 +174,7 @@ namespace mdlp {
sort(cutPoints.begin(), cutPoints.end());
return cutPoints;
}
int CPPFImdlp::get_depth()
int CPPFImdlp::get_depth() const
{
return depth;
}