Completed predict

This commit is contained in:
2023-11-06 17:11:39 +01:00
parent ed21f90b69
commit 418fb1444a
2 changed files with 23 additions and 33 deletions

View File

@@ -3,7 +3,7 @@
#include <iostream> #include <iostream>
namespace pywrap { namespace pywrap {
namespace p = boost::python; namespace bp = boost::python;
namespace np = boost::python::numpy; namespace np = boost::python::numpy;
PyClassifier::PyClassifier(const std::string& module, const std::string& className) : module(module), className(className) PyClassifier::PyClassifier(const std::string& module, const std::string& className) : module(module), className(className)
{ {
@@ -20,14 +20,14 @@ namespace pywrap {
{ {
int m = X.size(0); int m = X.size(0);
int n = X.size(1); int n = X.size(1);
auto Xn = np::from_data(X.data_ptr(), np::dtype::get_builtin<float>(), p::make_tuple(m, n), p::make_tuple(sizeof(X.dtype()) * 2 * n, sizeof(X.dtype()) * 2), p::object()); auto Xn = np::from_data(X.data_ptr(), np::dtype::get_builtin<float>(), bp::make_tuple(m, n), bp::make_tuple(sizeof(X.dtype()) * 2 * n, sizeof(X.dtype()) * 2), bp::object());
Xn = Xn.transpose(); Xn = Xn.transpose();
return Xn; return Xn;
} }
std::pair<np::ndarray, np::ndarray> tensors2numpy(torch::Tensor& X, torch::Tensor& y) std::pair<np::ndarray, np::ndarray> tensors2numpy(torch::Tensor& X, torch::Tensor& y)
{ {
int n = X.size(1); int n = X.size(1);
auto yn = np::from_data(y.data_ptr(), np::dtype::get_builtin<int32_t>(), p::make_tuple(n), p::make_tuple(sizeof(y.dtype()) * 2), p::object()); auto yn = np::from_data(y.data_ptr(), np::dtype::get_builtin<int32_t>(), bp::make_tuple(n), bp::make_tuple(sizeof(y.dtype()) * 2), bp::object());
return { tensor2numpy(X), yn }; return { tensor2numpy(X), yn };
} }
std::string PyClassifier::version() std::string PyClassifier::version()
@@ -41,50 +41,36 @@ namespace pywrap {
PyClassifier& PyClassifier::fit(torch::Tensor& X, torch::Tensor& y, const std::vector<std::string>& features, const std::string& className, std::map<std::string, std::vector<int>>& states) PyClassifier& PyClassifier::fit(torch::Tensor& X, torch::Tensor& y, const std::vector<std::string>& features, const std::string& className, std::map<std::string, std::vector<int>>& states)
{ {
auto [Xn, yn] = tensors2numpy(X, y); auto [Xn, yn] = tensors2numpy(X, y);
CPyObject Xp = p::incref(p::object(Xn).ptr()); CPyObject Xp = bp::incref(bp::object(Xn).ptr());
CPyObject yp = p::incref(p::object(yn).ptr()); CPyObject yp = bp::incref(bp::object(yn).ptr());
pyWrap->fit(module, this->className, Xp, yp); pyWrap->fit(module, this->className, Xp, yp);
return *this; return *this;
} }
void print_array(np::ndarray& array)
{
std::cout << "Array: " << std::endl;
std::cout << p::extract<char const*>(p::str(array)) << std::endl;
}
torch::Tensor PyClassifier::predict(torch::Tensor& X) torch::Tensor PyClassifier::predict(torch::Tensor& X)
{ {
int dimension = X.size(1); int dimension = X.size(1);
auto Xn = tensor2numpy(X); auto Xn = tensor2numpy(X);
CPyObject Xp = p::incref(p::object(Xn).ptr()); CPyObject Xp = bp::incref(bp::object(Xn).ptr());
PyObject* incoming = pyWrap->predict(module, className, Xp); PyObject* incoming = pyWrap->predict(module, className, Xp);
std::cout << "Return from predict" << std::endl; std::cout << "Return from predict" << std::endl;
p::handle<> handle(incoming); bp::handle<> handle(incoming);
p::object object(handle); bp::object object(handle);
np::ndarray prediction = np::from_object(object); np::ndarray prediction = np::from_object(object);
print_array(prediction); if (PyErr_Occurred()) {
// import_array(); PyErr_Print();
// if (!PyArray_Check(incoming)) { throw std::runtime_error("Error cleaning module " + module + " and class " + className);
// throw std::logic_error("Returned value is not array"); }
// } int* data = reinterpret_cast<int*>(prediction.get_data());
// std::cout << "Returned value is array" << std::endl; std::vector<int> v1(data, data + prediction.shape(0));
// PyArrayObject* np_ret = (PyArrayObject*)incoming; auto resultTensor = torch::tensor(v1, torch::kInt32);
// if (PyArray_NDIM(np_ret) != dimension - 1) { Py_XDECREF(incoming);
// throw std::logic_error("Returned array has wrong dimension" + std::to_string(PyArray_NDIM(np_ret)) + "!=" + std::to_string(dimension - 1));
// }
// std::cout << "Returned array has correct dimension" << PyArray_NDIM(np_ret) << std::endl;
// int len{ PyArray_SHAPE(np_ret)[0] };
// int* data = reinterpret_cast<int*>(PyArray_DATA(np_ret));
// int* data = reinterpret_cast<int*>(prediction.get_data());
// auto resultTensor = torch::tensor({ data }, torch::kInt32);
auto resultTensor = torch::zeros({ prediction.shape(0) }, torch::kInt32);
return resultTensor; return resultTensor;
} }
double PyClassifier::score(torch::Tensor& X, torch::Tensor& y) double PyClassifier::score(torch::Tensor& X, torch::Tensor& y)
{ {
auto [Xn, yn] = tensors2numpy(X, y); auto [Xn, yn] = tensors2numpy(X, y);
CPyObject Xp = p::incref(p::object(Xn).ptr()); CPyObject Xp = bp::incref(bp::object(Xn).ptr());
CPyObject yp = p::incref(p::object(yn).ptr()); CPyObject yp = bp::incref(bp::object(yn).ptr());
auto result = pyWrap->score(module, className, Xp, yp); auto result = pyWrap->score(module, className, Xp, yp);
return result; return result;
} }

View File

@@ -58,7 +58,11 @@ int main(int argc, char* argv[])
clf.fit(X, y, features, className, states); clf.fit(X, y, features, className, states);
// cout << "STree Score: " << clf.score(X, y) << endl; // cout << "STree Score: " << clf.score(X, y) << endl;
auto prediction = clf.predict(X); auto prediction = clf.predict(X);
cout << "Prediction: " << prediction << endl; cout << "Prediction: " << endl << "{";
for (int i = 0; i < prediction.size(0); ++i) {
cout << prediction[i].item<int>() << ", ";
}
cout << "}" << endl;
} }
cout << "* End." << endl; cout << "* End." << endl;
} }