Some lint suggestions refactoring

This commit is contained in:
2024-02-08 17:27:19 +01:00
parent b490d406a2
commit 0907906ef6
5 changed files with 6 additions and 8 deletions

View File

@@ -5,7 +5,7 @@
#include "Colors.h" #include "Colors.h"
#include "config.h" #include "config.h"
void manageArguments(argparse::ArgumentParser& program, int argc, char** argv) void manageArguments(argparse::ArgumentParser& program)
{ {
program.add_argument("-m", "--model").default_value("").help("Filter results of the selected model) (any for all models)"); program.add_argument("-m", "--model").default_value("").help("Filter results of the selected model) (any for all models)");
program.add_argument("-s", "--score").default_value("accuracy").help("Filter results of the score name supplied"); program.add_argument("-s", "--score").default_value("accuracy").help("Filter results of the score name supplied");
@@ -30,7 +30,7 @@ void manageArguments(argparse::ArgumentParser& program, int argc, char** argv)
int main(int argc, char** argv) int main(int argc, char** argv)
{ {
argparse::ArgumentParser program("b_best", { project_version.begin(), project_version.end() }); argparse::ArgumentParser program("b_best", { project_version.begin(), project_version.end() });
manageArguments(program, argc, argv); manageArguments(program);
std::string model, score; std::string model, score;
bool build, report, friedman, excel; bool build, report, friedman, excel;
double level; double level;

View File

@@ -2,7 +2,6 @@
#include <set> #include <set>
#include <fstream> #include <fstream>
#include <iostream> #include <iostream>
#include <sstream>
#include <algorithm> #include <algorithm>
#include "BestResults.h" #include "BestResults.h"
#include "Result.h" #include "Result.h"
@@ -64,7 +63,6 @@ namespace platform {
std::pair<std::string, std::string> getModelScore(std::string name) std::pair<std::string, std::string> getModelScore(std::string name)
{ {
// results_accuracy_BoostAODE_MacBookpro16_2023-09-06_12:27:00_1.json // results_accuracy_BoostAODE_MacBookpro16_2023-09-06_12:27:00_1.json
int i = 0;
auto pos = name.find("_"); auto pos = name.find("_");
auto pos2 = name.find("_", pos + 1); auto pos2 = name.find("_", pos + 1);
std::string score = name.substr(pos + 1, pos2 - pos - 1); std::string score = name.substr(pos + 1, pos2 - pos - 1);
@@ -138,7 +136,7 @@ namespace platform {
std::cout << model << ", "; std::cout << model << ", ";
build(); build();
} }
std::cout << "end." << std::endl << std::endl;; std::cout << "end." << std::endl << std::endl;
model = "any"; model = "any";
} }
void BestResults::listFile() void BestResults::listFile()

View File

@@ -1,7 +1,7 @@
#include "Models.h" #include "Models.h"
namespace platform { namespace platform {
// Idea from: https://www.codeproject.com/Articles/567242/AplusC-2b-2bplusObjectplusFactory // Idea from: https://www.codeproject.com/Articles/567242/AplusC-2b-2bplusObjectplusFactory
Models* Models::factory = nullptr;; Models* Models::factory = nullptr;
Models* Models::instance() Models* Models::instance()
{ {
//manages singleton //manages singleton

View File

@@ -11,7 +11,7 @@ namespace platform {
} else { } else {
maxModel = 0; maxModel = 0;
} }
}; }
void Results::load() void Results::load()
{ {
using std::filesystem::directory_iterator; using std::filesystem::directory_iterator;

View File

@@ -15,7 +15,7 @@ namespace platform {
nModels = models.size(); nModels = models.size();
nDatasets = datasets.size(); nDatasets = datasets.size();
auto temp = ConfigLocale(); auto temp = ConfigLocale();
}; }
void Statistics::fit() void Statistics::fit()
{ {