Refactor Cestnik smoothin factor assuming m=1

2024-06-13 09:11:47 +02:00
parent b34869cc61
commit ca0ae4dacf
3 changed files with 70 additions and 5 deletions
--- a/bayesnet/network/Network.cc
+++ b/bayesnet/network/Network.cc
@@ -204,8 +204,8 @@ namespace bayesnet {
                    case Smoothing_t::LAPLACE:
                        smoothing_factor = 1.0;
                        break;
-                    case Smoothing_t::CESTNIK:
-                        smoothing_factor = n_samples / numStates;
+                    case Smoothing_t::CESTNIK: // Considering m=1 pa = 1/numStates
+                        smoothing_factor = 1 / numStates;
                        break;
                    default:
                        throw std::invalid_argument("Smoothing method not recognized " + std::to_string(static_cast<int>(smoothing)));