diff --git a/CHANGELOG.md b/CHANGELOG.md index 8fe3f62..688e598 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Add a new hyperparameter to the SPODE class, *parent*, to set the root node of the model. If no value is set the root parameter of the constructor is used. - Add a new hyperparameter to the TAN class, *parent*, to set the root node of the model. If not set the first feature is used as root. +### Changed + +- Hyperparameter *maxTolerance* in the BoostAODE class is now in [1, 6] range (it was in [1, 4] range before). + ## [1.0.6] 2024-11-23 ### Fixed diff --git a/bayesnet/ensembles/Boost.cc b/bayesnet/ensembles/Boost.cc index 50f3c73..7a3381e 100644 --- a/bayesnet/ensembles/Boost.cc +++ b/bayesnet/ensembles/Boost.cc @@ -48,8 +48,8 @@ namespace bayesnet { } if (hyperparameters.contains("maxTolerance")) { maxTolerance = hyperparameters["maxTolerance"]; - if (maxTolerance < 1 || maxTolerance > 4) - throw std::invalid_argument("Invalid maxTolerance value, must be greater in [1, 4]"); + if (maxTolerance < 1 || maxTolerance > 6) + throw std::invalid_argument("Invalid maxTolerance value, must be greater in [1, 6]"); hyperparameters.erase("maxTolerance"); } if (hyperparameters.contains("predict_voting")) { diff --git a/tests/TestBoostA2DE.cc b/tests/TestBoostA2DE.cc index c486b91..d781adc 100644 --- a/tests/TestBoostA2DE.cc +++ b/tests/TestBoostA2DE.cc @@ -123,7 +123,7 @@ TEST_CASE("Oddities2", "[BoostA2DE]") { { "order", "duck" } }, { { "select_features", "duck" } }, { { "maxTolerance", 0 } }, - { { "maxTolerance", 5 } }, + { { "maxTolerance", 7 } }, }; for (const auto& hyper : bad_hyper.items()) { INFO("BoostA2DE hyper: " + hyper.value().dump()); diff --git a/tests/TestBoostAODE.cc b/tests/TestBoostAODE.cc index 728f35b..d21e449 100644 --- a/tests/TestBoostAODE.cc +++ b/tests/TestBoostAODE.cc @@ -118,7 +118,7 @@ TEST_CASE("Oddities", "[BoostAODE]") { { "order", "duck" } }, { { "select_features", "duck" } }, { { "maxTolerance", 0 } }, - { { "maxTolerance", 5 } }, + { { "maxTolerance", 7 } }, }; for (const auto& hyper : bad_hyper.items()) { INFO("BoostAODE hyper: " << hyper.value().dump());