Refactor hyperparameters classifier management

2024-04-08 00:55:30 +02:00
parent 0d6a081d01
commit 9014649a0d
8 changed files with 43 additions and 15 deletions
--- a/bayesnet/classifiers/KDB.cc
+++ b/bayesnet/classifiers/KDB.cc
@@ -6,14 +6,18 @@ namespace bayesnet {
        validHyperparameters = { "k", "theta" };

    }
-    void KDB::setHyperparameters(const nlohmann::json& hyperparameters)
+    void KDB::setHyperparameters(const nlohmann::json& hyperparameters_)
    {
+        auto hyperparameters = hyperparameters_;
        if (hyperparameters.contains("k")) {
            k = hyperparameters["k"];
+            hyperparameters.erase("k");
        }
        if (hyperparameters.contains("theta")) {
            theta = hyperparameters["theta"];
+            hyperparameters.erase("theta");
        }
+        Classifier::setHyperparameters(hyperparameters);
    }
    void KDB::buildModel(const torch::Tensor& weights)
    {