Refactor Hyperparameters management

2023-11-19 22:36:27 +01:00
parent 89c4613591
commit 4f3a04058f
21 changed files with 1070 additions and 78 deletions
--- a/src/Platform/Experiment.cc
+++ b/src/Platform/Experiment.cc
@@ -170,9 +170,9 @@ namespace platform {
            for (int nfold = 0; nfold < nfolds; nfold++) {
                auto clf = Models::instance()->create(model);
                setModelVersion(clf->getVersion());
-                if (hyperparameters.notEmpty(fileName)) {
-                    clf->setHyperparameters(hyperparameters.get(fileName));
-                }
+                auto valid = clf->getValidHyperparameters();
+                hyperparameters.check(valid, fileName);
+                clf->setHyperparameters(hyperparameters.get(fileName));
                // Split train - test dataset
                train_timer.start();
                auto [train, test] = fold->getFold(nfold);