From cc931d8547659bea0ac01f239af64348be639f37 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ricardo=20Montan=CC=83ana?= Date: Thu, 4 Nov 2021 10:04:30 +0100 Subject: [PATCH] Fix random seed not used in fs_mutual --- .github/workflows/main.yml | 2 +- stree/Splitter.py | 7 ++++--- stree/__init__.py | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index cce8b96..f7385f0 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -12,7 +12,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - os: [macos-latest, ubuntu-latest] + os: [macos-latest, ubuntu-latest, windows-latest] python: [3.8] steps: diff --git a/stree/Splitter.py b/stree/Splitter.py index 5c78775..2829503 100644 --- a/stree/Splitter.py +++ b/stree/Splitter.py @@ -367,9 +367,8 @@ class Splitter: .get_support(indices=True) ) - @staticmethod def _fs_mutual( - dataset: np.array, labels: np.array, max_features: int + self, dataset: np.array, labels: np.array, max_features: int ) -> tuple: """Return the best features with mutual information with labels @@ -389,7 +388,9 @@ class Splitter: indices of the features selected """ # return best features with mutual info with the label - feature_list = mutual_info_classif(dataset, labels) + feature_list = mutual_info_classif( + dataset, labels, random_state=self._random_state + ) return tuple( sorted( range(len(feature_list)), key=lambda sub: feature_list[sub] diff --git a/stree/__init__.py b/stree/__init__.py index 03c70d4..546ee03 100644 --- a/stree/__init__.py +++ b/stree/__init__.py @@ -1,6 +1,6 @@ from .Strees import Stree, Siterator -__version__ = "1.2.2" +__version__ = "1.2.3" __author__ = "Ricardo Montañana Gómez" __copyright__ = "Copyright 2020-2021, Ricardo Montañana Gómez"