Add constant features treatment

.github/workflows/build.yml

@@ -1,23 +0,0 @@
-name: Build
-on:
-  push:
-    branches:
-      - main
-jobs:
-  build:
-    name: Build
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
-      - uses: sonarsource/sonarqube-scan-action@master
-        env:
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-          SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
-      # If you wish to fail your job when the Quality Gate is red, uncomment the
-      # following lines. This would typically be used to fail a deployment.
-      - uses: sonarsource/sonarqube-quality-gate-action@master
-        timeout-minutes: 5
-        env:
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.github/workflows/main.yml

@@ -12,11 +12,13 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [macos-latest, ubuntu-latest]
-        python: [3.8, "3.10"]
+        os: [ubuntu-latest]
+        python: ["3.10"]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
       - name: Set up Python ${{ matrix.python }}
         uses: actions/setup-python@v2
         with:
@@ -28,12 +30,35 @@ jobs:
           pip install -q numpy
           pip install -q git+https://github.com/doctorado-ml/mdlp
           pip install -q -r requirements/dev.txt
-          pip install -q --upgrade codecov coverage black flake8 codacy-coverage
+          pip install -q --upgrade codecov coverage black flake8 codacy-coverage unittest-xml-reporting
       - name: Lint
         run: |
           black --check --diff mufs
           flake8 --count mufs
       - name: Tests & coverage
         run: |
-          coverage run -m unittest -v mufs.tests
+          mkdir .report
+          coverage run -m xmlrunner -v mufs.tests -o .report
+          coverage xml -i -o .report/coverage.xml
           coverage report -m --fail-under=100
+      - name: Get project version
+        run: echo "project_version=$(git describe --tags --abbrev=0)" >> $GITHUB_ENV
+      - name: Override Coverage Source Path for Sonar
+        run: sed -i 's/\/home\/runner\/work\/mufs\/mufs\//\/github\/workspace\//g' .report/coverage.xml
+      - name: SonarQube scanner
+        uses: sonarsource/sonarqube-scan-action@master
+        env:
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
+          SONAR_HOST_URL: ${{ secrets.SONAR_HOST_URL }}
+        with:
+          args: >
+            -Dsonar.projectVersion=${{ env.project_version }}
+            -Dsonar.python.coverage.reportPaths=.report/coverage.xml
+            -Dsonar.python.xunit.reportPath=.report/TEST*
+        # If you wish to fail your job when the Quality Gate is red, uncomment the
+        # following lines. This would typically be used to fail a deployment.
+      - name: Quality Gate
+        uses: sonarsource/sonarqube-quality-gate-action@master
+        timeout-minutes: 5
+        env:
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.pre-commit-config.yaml

@@ -1,12 +1,12 @@
 repos:
   - repo: https://github.com/ambv/black
-    rev: 20.8b1
+    rev: 22.3.0
     hooks:
       - id: black
         exclude: ".virtual_documents"
         language_version: python3.8
   - repo: https://gitlab.com/pycqa/flake8
-    rev: 3.8.4
+    rev: 3.9.2
     hooks:
       - id: flake8
         exclude: ".virtual_documents"
@@ -16,7 +16,7 @@ repos:
   #     - id: mypy
   #       # args: [--strict, --ignore-missing-imports]
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    rev: v3.4.0
+    rev: v4.2.0
     hooks:
       - id: trailing-whitespace
       - id: check-case-conflict

README.md

@@ -2,9 +2,9 @@
 [![Codacy Badge](https://app.codacy.com/project/badge/Grade/66ad727eb13e4c7a8816db1e44d994a7)](https://www.codacy.com/gh/Doctorado-ML/mufs/dashboard?utm_source=github.com&utm_medium=referral&utm_content=Doctorado-ML/mufs&utm_campaign=Badge_Grade)
 [![Language grade: Python](https://img.shields.io/lgtm/grade/python/g/Doctorado-ML/mufs.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/Doctorado-ML/mufs/context:python)
 [![PyPI version](https://badge.fury.io/py/MUFS.svg)](https://badge.fury.io/py/MUFS)
+[![Technical Debt](https://haystack.rmontanana.es:25000/api/project_badges/measure?project=mufs&metric=sqale_index&token=1119a3bfd4025d50ef3009a44c600c16670ee31a)](https://haystack.rmontanana.es:25000/dashboard?id=mufs)
+[![Quality Gate Status](https://haystack.rmontanana.es:25000/api/project_badges/measure?project=mufs&metric=alert_status&token=1119a3bfd4025d50ef3009a44c600c16670ee31a)](https://haystack.rmontanana.es:25000/dashboard?id=mufs)
 ![https://img.shields.io/badge/python-3.8%2B-blue](https://img.shields.io/badge/python-3.8%2B-brightgreen)
-[![Security Rating](https://haystack.rmontanana.es:25000/api/project_badges/measure?project=mufs&metric=security_rating&token=1119a3bfd4025d50ef3009a44c600c16670ee31a)](http://haystack.local:25000/dashboard?id=mufs)
-[![Technical Debt](https://haystack.rmontanana.es:25000/api/project_badges/measure?project=mufs&metric=sqale_index&token=1119a3bfd4025d50ef3009a44c600c16670ee31a)](http://haystack.local:25000/dashboard?id=mufs)
 
 # MUFS
 

mufs/Selection.py

@@ -172,6 +172,10 @@ class MUFS:
                     id_selected = idx
                     merit = merit_new
                 candidates.pop()
+            if id_selected is None:
+                # No more features to add all merits are nan because of
+                # constant features
+                break
             candidates.append(feature_order[id_selected])
             self._scores.append(merit)
             del feature_order[id_selected]

requirements/dev.txt

@@ -1,3 +1,3 @@
 -r production.txt
 mdlp
-pandas
+pandas

sonar-project.properties

@@ -1 +1,4 @@
 sonar.projectKey=mufs
+sonar.sourceEncoding=UTF-8
+sonar.sources=.
+sonar.python.version=3.8, 3.9, 3.10