Remove ignore-nan from .env files

leave only as be_main hyperparameter
This commit is contained in:
2023-01-08 12:25:59 +01:00
parent 132d7827c3
commit ae52148021
7 changed files with 12 additions and 20 deletions

View File

@@ -126,9 +126,9 @@ class Arguments(argparse.ArgumentParser):
"ignore_nan": [ "ignore_nan": [
("--ignore-nan",), ("--ignore-nan",),
{ {
"action": EnvDefault, "default": False,
"envvar": "ignore_nan", "action": "store_true",
"required": True, "required": False,
"help": "Ignore nan results", "help": "Ignore nan results",
}, },
], ],

View File

@@ -28,6 +28,11 @@ class MockModel(SVC):
def nodes_leaves(self): def nodes_leaves(self):
return 0, 0 return 0, 0
def fit(self, X, y, **kwargs):
kwargs.pop("state_names", None)
kwargs.pop("features", None)
return super().fit(X, y, **kwargs)
class Models: class Models:
@staticmethod @staticmethod

View File

@@ -7,4 +7,3 @@ stratified=0
source_data=Tanveer source_data=Tanveer
seeds=[57, 31, 1714, 17, 23, 79, 83, 97, 7, 1] seeds=[57, 31, 1714, 17, 23, 79, 83, 97, 7, 1]
discretize=0 discretize=0
ignore_nan=0

View File

@@ -6,4 +6,3 @@ stratified=0
source_data=Arff source_data=Arff
seeds=[271, 314, 171] seeds=[271, 314, 171]
discretize=1 discretize=1
ignore_nan=1

View File

@@ -7,4 +7,3 @@ stratified=0
source_data=Tanveer source_data=Tanveer
seeds=[57, 31, 1714, 17, 23, 79, 83, 97, 7, 1] seeds=[57, 31, 1714, 17, 23, 79, 83, 97, 7, 1]
discretize=0 discretize=0
ignore_nan=0

View File

@@ -7,4 +7,3 @@ stratified=0
source_data=Surcov source_data=Surcov
seeds=[57, 31, 1714, 17, 23, 79, 83, 97, 7, 1] seeds=[57, 31, 1714, 17, 23, 79, 83, 97, 7, 1]
discretize=0 discretize=0
ignore_nan=0

View File

@@ -180,7 +180,6 @@ class UtilTest(TestBase):
"source_data": "Tanveer", "source_data": "Tanveer",
"seeds": "[57, 31, 1714, 17, 23, 79, 83, 97, 7, 1]", "seeds": "[57, 31, 1714, 17, 23, 79, 83, 97, 7, 1]",
"discretize": "0", "discretize": "0",
"ignore_nan": "0",
} }
computed = EnvData().load() computed = EnvData().load()
self.assertDictEqual(computed, expected) self.assertDictEqual(computed, expected)
@@ -192,16 +191,8 @@ class UtilTest(TestBase):
"n_folds": 5, "n_folds": 5,
"model": "STree", "model": "STree",
"stratified": "0", "stratified": "0",
"ignore_nan": "0",
} }
ap = argparse.ArgumentParser() ap = argparse.ArgumentParser()
ap.add_argument(
"--ignore-nan",
action=EnvDefault,
envvar="ignore_nan",
required=True,
help="Ignore nan results",
)
ap.add_argument( ap.add_argument(
"-s", "-s",
"--score", "--score",