From 5d07e043e5b09c8cc5ca3ee6b1d792e678ac4ce3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ricardo=20Montan=CC=83ana?= Date: Tue, 26 Apr 2022 18:39:15 +0200 Subject: [PATCH] Fix test --- benchmark/Results.py | 14 ++++++++------ benchmark/tests/PairCheck_test.py | 7 +++++++ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/benchmark/Results.py b/benchmark/Results.py index 17cac14..f51a2d3 100644 --- a/benchmark/Results.py +++ b/benchmark/Results.py @@ -1252,13 +1252,15 @@ class PairCheck: self.score_b = report_b.score for result_a, result_b in zip(report_a.lines, report_b.lines): result = result_a["score"] - result_b["score"] + self._store_result(result, result_a["dataset"]) - if result > 0: - self.winners.append(result_a["dataset"]) - elif result < 0: - self.losers.append(result_a["dataset"]) - else: - self.tie.append(result_a["dataset"]) + def _store_result(self, result, dataset): + if result > 0: + self.winners.append(dataset) + elif result < 0: + self.losers.append(dataset) + else: + self.tie.append(dataset) def report(self): print(f"{'Model':<20} {'File':<70} {'Score':<10} Win Tie Lose") diff --git a/benchmark/tests/PairCheck_test.py b/benchmark/tests/PairCheck_test.py index f0db27f..6a95791 100644 --- a/benchmark/tests/PairCheck_test.py +++ b/benchmark/tests/PairCheck_test.py @@ -63,3 +63,10 @@ class PairCheckTest(unittest.TestCase): ) as f: expected = f.read() self.assertEqual(computed, expected) + + def test_pair_check_store_result(self): + report = self.build_model(win=True, lose=True) + report.compute() + report._store_result(0, "balloons") + report._store_result(1, "balloons") + report._store_result(-1, "balloons")