From 4c7110214b27a12687471c18404644f20458e022 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ricardo=20Montan=CC=83ana?= Date: Thu, 5 May 2022 13:11:39 +0200 Subject: [PATCH] Fix some issues --- benchmark/Arguments.py | 5 +++-- benchmark/scripts/be_pair_check.py | 6 +++--- benchmark/scripts/be_print_strees.py | 2 +- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/benchmark/Arguments.py b/benchmark/Arguments.py index 3325d62..57a214e 100644 --- a/benchmark/Arguments.py +++ b/benchmark/Arguments.py @@ -28,8 +28,9 @@ class EnvDefault(argparse.Action): # Thanks to https://stackoverflow.com/users/445507/russell-heilling def __init__(self, envvar, required=True, default=None, **kwargs): self._args = EnvData.load() - default = self._args[envvar] - required = False + if required: + default = self._args[envvar] + required = False super(EnvDefault, self).__init__( default=default, required=required, **kwargs ) diff --git a/benchmark/scripts/be_pair_check.py b/benchmark/scripts/be_pair_check.py index 39d230a..21e25f2 100755 --- a/benchmark/scripts/be_pair_check.py +++ b/benchmark/scripts/be_pair_check.py @@ -1,6 +1,6 @@ #!/usr/bin/env python from benchmark.Results import PairCheck -from Arguments import Arguments +from benchmark.Arguments import Arguments """Check best results of two models giving scores and win-tie-loose results """ @@ -15,8 +15,8 @@ def main(): args.score, args.model1, args.model2, - args.win_results, - args.lose_results, + args.win, + args.lose, ) pair_check.compute() pair_check.report() diff --git a/benchmark/scripts/be_print_strees.py b/benchmark/scripts/be_print_strees.py index 66d6e13..a359287 100755 --- a/benchmark/scripts/be_print_strees.py +++ b/benchmark/scripts/be_print_strees.py @@ -6,7 +6,7 @@ from stree import Stree from graphviz import Source from benchmark.Experiments import Datasets from benchmark.Utils import Files, Folders -from Arguments import Arguments +from benchmark.Arguments import Arguments def compute_stree(X, y, random_state):